Implemented resending of data when performing a flash in buffered output#407
Merged
Conversation
|
|
dngrudin
force-pushed
the
resend_on_flash
branch
from
0f1d5b9 to
b71972c
Compare
Enmk
approved these changes
Dec 20, 2024
Enmk
left a comment
Enmk
left a comment
Contributor
There was a problem hiding this comment.
LGTM, can be merged after all tests are passing
Contributor
Author
@Enmk If there are no more questions for the pull request, can you do the merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Enmk These are additional corrections necessary for the correct operation of the changes implemented in the PR #407. Implement resend when performing a flash on a buffered output. Please check.